Add is_copper definition to cmis api #500
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbymcgonigle
force-pushed
the
master-cmuis-is-copper
branch
from
2a2773f
to
b236656
Compare
prgeor
reviewed
Oct 22, 2024
| Returns True if the module is copper, False otherwise | ||
| ''' | ||
| media_intf = self.get_module_media_type() | ||
| return media_intf == "passive_copper_media_interface" or media_intf == "active_cable_media_interface" |
There was a problem hiding this comment.
@Active cable is not passive media. Active cables like AEC have datapath state machine. @mihirpat1 can you check
There was a problem hiding this comment.
@prgeor Confirmed that active cables like AEC have datapath state machine. Hence, this check needs to be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For CMIS it's pretty easy to tell if a module is copper because the media interface will always be either passive_copper_media_interface or active_cable_media_interface. This PR adds a check for that.
Motivation and Context
Similar to other SFF xcvr api's it would be helpful to know if a CMIS module is copper or optical. We can use this information for tunings and in other areas where appropriate.
How Has This Been Tested?
Manually tested a lot of copper and optical modules ensuring they return the correct type.
Additional Information (Optional)
Please cast this to 202405 also - I've made sure that the diff applies successfully